Skip to content

Irsa 717 add pdf button #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2017
Merged

Irsa 717 add pdf button #461

merged 2 commits into from
Sep 20, 2017

Conversation

lznakano
Copy link
Contributor

This is the part of the fixes for the IRSA-809.
Please check it out along with the branch in IFE to test the finderchart:
The changes are:

  1. The IRIS/IRAS images can be displayed in the grids
  2. The IRIS images are able to be downloaded
  3. Add "Include PNG Color Images" button in the dialog and enable the search functionality
  4. Rearrange and align all the buttons in the DownloadDialog

Lijun Zhang added 2 commits September 12, 2017 11:29
IRSA-717:
54233fc 
  Add the pdf icon to the images
IRSA-717:
3f39144 
IRSA-809
  Fixed the but in WebPlotRequest where set the drawingSubGroup to irsa instead of iras
@lznakano lznakano requested a review from ejoliet September 20, 2017 00:38
ejoliet
ejoliet approved these changes Sep 20, 2017
View reviewed changes
Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks!

@lznakano lznakano merged commit dc434aa into dev Sep 20, 2017
@lznakano lznakano deleted the IRSA-717-addPDFButton branch September 20, 2017 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejoliet ejoliet ejoliet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lznakano @ejoliet