IRSA-481: finder chart grid result view #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loitly
approved these changes
Sep 5, 2017
- added more MultiImageViewer grid layout support - fixed wcs match bug - added better subgrouping support in WebPlotRequest - clean up of some wcs matching code - three color working (IRSA-722) - three color can be added a removed (IRSA-138) - Added passing of expanded mode function to hydra - expanded mode - added icons - more toolbar with all icons - did some refactoring and cleanup of wcs match code - support for subgrouping
robyww
force-pushed
the
irsa-481-fc-view
branch
from
5c27c48 to
3a4260f
Compare
lznakano
approved these changes
Sep 6, 2017
|
Sorry, I just realized that I need to check out the finderchart in ife. I tested it again. Everything works great! Please ignore my previous comments. You can merge it. Thanks! |
|
@robyww thank you for not only implementing the issue but fixing bugs and improving the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The following file are just have code cleanup that does not really need review: