Skip to content

IRSA-701: fixed wcs match getting out of aligement when multi image viewer goes from single to multi #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2017

Conversation

robyww
Copy link
Contributor

@robyww robyww commented Aug 24, 2017

to test:
ticket description: https://caltech-ipac.atlassian.net/browse/IRSA-701
also- confirm time series stays in alignment which which between 1-3-5-7

Note 8-25-17: fixed server more bugs:

  • found more much in wcs match and target match
  • Target match being lost in certain cases
  • Selection showing image bounds in unrotated case
  • Expanded view not sizing to fit when more plots are added
  • In certain cases deleting a plot was causing an exception

@robyww robyww requested a review from ejoliet August 24, 2017 00:26
@ejoliet
Copy link
Contributor

ejoliet commented Aug 24, 2017

I've tested it in tri-view and is working fine now. It's fixed.

Now, i've been testing in LC app the "target match", and i've found that somehow the "target match" is lost if i zoom in an image and then scroll through rows on the table. The images are not centered/aligned. This is a new bug discovered, it happens in dev too. A workaround is to uncheck and check back the "target match" feature.
(A side note: LC app doesn't have single and multi grid mode)

Unless you think is related to this fix, you can merge into rc.

(I will raise a new ticket to be fixed in dev later on for LC target match when images are zoomed in.)

Thank you!

  - found more much in wcs match and target match
  - Target match being lost in certain cases
  - Selection showing image bounds in unrotated case
  - Expanded view not sizing to fit when more plots are added
  - In certain cases deleting a plot was causing an exception
@robyww robyww self-assigned this Aug 25, 2017
@robyww robyww merged commit a351a60 into rc Aug 25, 2017
@robyww robyww deleted the irsa-701 branch September 25, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants