Skip to content

IRSA_672: improve image lable for plot title inline #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2017
Merged

IRSA_672: improve image lable for plot title inline #448

merged 2 commits into from
Aug 25, 2017

Conversation

ejoliet
Copy link
Contributor

@ejoliet ejoliet commented Aug 23, 2017

Improve image title label by changing the line height (css).
This is also solving the problem that in smaller screen, the zoom level wasn't shown.

Check that it doesn't break anything.

@ejoliet ejoliet requested a review from robyww August 23, 2017 01:32
robyww
robyww approved these changes Aug 25, 2017
View reviewed changes
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try is now. It is like we talked about: added overflow, ellipsis, and max width.

@ejoliet
Copy link
Contributor Author

ejoliet commented Aug 25, 2017

Looks great! Thanks for the improvement! Will merge now.

@ejoliet ejoliet merged commit 14bf3ed into dev Aug 25, 2017
@ejoliet ejoliet deleted the IRSA-672-image-plot-title branch August 25, 2017 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyww robyww robyww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejoliet @robyww