IRSA-503:Migrated Finderchart needs a control button to switch from table view to chart view and vice-versa #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug in HydraViewer.jsx. The closable is not defined in the layout mode. Thus, the closable is always no defined.
However it is used in all three contaniners as closable={closeable}. Since the closeable is always undefined, it caused the
the xyPlot's, imagePlots, the close button was gone.
ejoliet
approved these changes
Aug 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the branch implementation was about fixing a bug in HydraViewer.jsx. The closable is not defined in the layout mode. Thus, the closable is always no defined.
However it is used in all three contaniners as closable={closeable}. Since the closeable is always undefined, it caused the
the xyPlot's, imagePlots, the close button was gone.
The other part is done in IFE.