Skip to content

DM-11569 Plotly 3d bug fixes #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2017
Merged

DM-11569 Plotly 3d bug fixes #439

merged 4 commits into from
Aug 11, 2017

Conversation

tgoldina
Copy link
Contributor

https://jira.lsstcorp.org/browse/DM-11569

Bug fixes, related to scatter3d (and 3d plots in general):

  • 2d axes should not show
  • options should be basic (not scatter) and should not include options for 2d XY
  • drag mode buttons should be those that are supported for 3d (temporary buttons are used for turntable and orbital rotations)
  • selection button should not show unless chart supports selection
  • zoom to original should work

To test, use http://localhost:8080/firefly/demo/ffapi-slate-test2.html

@tgoldina tgoldina requested review from cwang2016 and robyww August 11, 2017 00:05
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Much better than before. I like the simple side bar.

  • I cleaned up the rotate icon a little more, it is still not good but a little better. Make sure you do a pull.
  • Make sure you pick up all of cindy's update for ffapi-slate-test2.html

@cwang2016
Copy link
Contributor

As looking at the chart cases in ffapi-slate-test2.html, the x, y for the chart can be re-stated as an expression in 'trace' definition (like x: "tables:wiseCatTbl,w1mpro-w2mpro") for dataType 'fireflyScatter', 'fireflyHeatmap', or 'fireflyHistogram'. As for 'scatter3d' chart case, x, y, z doesn't work as an expression. Does that work as designed?

@cwang2016
Copy link
Contributor

Review completes. Works for 3d.

@tgoldina tgoldina merged commit 8247dc2 into dev Aug 11, 2017
@tgoldina tgoldina deleted the DM-11569_chart3d branch September 25, 2017 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants