Skip to content

DM-11424: filter on selected row fails on sorted table. #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2017
Merged

DM-11424: filter on selected row fails on sorted table. #435

merged 1 commit into from
Aug 3, 2017

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Aug 3, 2017

https://jira.lsstcorp.org/browse/DM-11424

To test:

  • build firefly on this branch
  • bring up a table, sort one of the columns
  • select a few rows, then filter on the selected rows.

Something else to test is the 'show selected' button on http://localhost:8080/firefly/demo/ffapi-highlevel-test.html

  • selecting a few rows then click the button

@loitly loitly requested review from ejoliet and wmiipac August 3, 2017 18:10
wmiipac
wmiipac approved these changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@wmiipac wmiipac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected. tested getSelectedData as well, work fine. nothing broken. PR approved

ejoliet
ejoliet approved these changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfect. Thanks!

@loitly loitly merged commit 62d3d01 into dev Aug 3, 2017
@loitly loitly deleted the DM-11424_filter_selected_row_fail branch August 3, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejoliet ejoliet ejoliet approved these changes

@wmiipac wmiipac wmiipac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loitly @ejoliet @wmiipac