Skip to content

DM-11458: Periodogram table rows are no longer selectable and highlighted #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Aug 3, 2017

https://jira.lsstcorp.org/browse/DM-11458

Fixes what's described in the ticket.
Also, fixes finderchart multi-position table not showing.

@loitly loitly requested review from ejoliet and lznakano August 3, 2017 16:37
Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works again! Good to be merged. Thanks!

@@ -122,7 +122,7 @@ function buildTablePart(llApi) {
* @prop {string} tbl_group the group this table belongs to. Defaults to 'main'.
* @prop {number} pageSize the starting page size. Will use the request's pageSize if not given.
* @prop {boolean} removable true if this table can be removed from view. Defaults to true.
* @prop {boolean} backgroundable true if this search can be sent to background. Defaults to true.
* @prop {boolean} backgroundable true if this search can be sent to background. Defaults to false.
* @prop {boolean} showUnits defaults to false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch to update the docs!

@loitly loitly merged commit 420dd6f into dev Aug 3, 2017
@loitly loitly deleted the DM-11458_periodogram_table_select branch August 3, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants