Skip to content

DM-11349 Time Series data display issues regarding overlay's position and overlay's rendering #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2017

Conversation

cwang2016
Copy link
Contributor

@cwang2016 cwang2016 commented Aug 3, 2017

This development fixes the following issues:

  1. The overlay position is not the same as the position of the selected source from LSST WISE search result.
    PADC WISE source names ra/dec columns differently from what IRSA WISE source does.
  2. The overlay (like the PointSelection symbol by turning on 'lock by click') is not shown on the plot as using the cursor to go down the table to highlight the row.
    All kinds of overlays, such the one for 'Select Area', 'Distance Tool', 'Marker', 'Footprint', 'Region', 'NorthUpCompass', 'Point Selection', 'Web Grid', are fixed to be rendered as the selected row of the table is changed up and down.

Test
for issue 1, start suit: localhost:8080/suit,
for issue 2, you may just start from firefly: localhost:800/firefly/ts.html and upload a wise table.

issue 1: from catalog search panel, select WISE_00 -> AllWISE Source Catalog
target m81 -> search
on tri-view page, click 'view time series: xxxxxx' button
move to Time Series Tool: Viewer

  • for issue 1: check the target overlay position in each plot and the source position shown in the table.

issue 2: on Time Series Tool: Viewer,

  • select any overlay, ex. Point selection by turning on 'Lock by click', Distance tool,, marker, or Region, etc, and move the cursor down to select the row of the table and see the overlay is shown on all plots.

…rveQuery. Solve the issue to attach the existing drawing layers to the newly created plots.
@cwang2016 cwang2016 requested review from robyww and ejoliet August 3, 2017 01:22
Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 2: That's good that someone found the bug and you fix it. You basically apply the overlay tool to all the images and that's the right thing to do. I've checked is working fine. Thank you!
Reviewed.

…etaching draw layer from the plot,

and the use of these two functons.
@xiuqin
Copy link
Contributor

xiuqin commented Aug 4, 2017

The "lock by click" point still does now show up in the image as I move cursor.
To make the test easier, I only selected to display one image at a time.

The build was on mater suit branch, and DM-11349-TSDataDisplay firefly branch.

Please disregard the above comment. User error in testing. The web page was not properly refreshed with the new build.

Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about the code face-to-face earlier. Everything looks good now. I am glad you were able to figure out a way not to use the boolean. It is a lot clearer and overall works much better than before.

@cwang2016 cwang2016 merged commit e8d4800 into dev Aug 4, 2017
@cwang2016 cwang2016 deleted the DM-11349-TSDataDisplay branch August 4, 2017 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants