Dm 11387 Add ability to limit what will appears as background jobs #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- on fail search, mask panel remained without error messages. - API should have backgroundable set to false, since background monitor may not be available.
…for catalog and suit searches.
ejoliet
requested changes
Aug 1, 2017
There was a problem hiding this comment.
Couple of things i've noticed that you might want to check (and fix) before merging:
- Email notification doesn't reset, keep repopulating the email in the input field.
- Prepare for download dialog keeps shown even after the job is done.
I've checked the rest and it looks good.
- added a checkbox to enable email notification - sync the checkbox and email field between download dialog and background monitor - remove 'resend email' feature which is confusing - when email notification is enabled, an email will be sent for each job when it's completed.
|
I've push a new commit which fixes several issues related to backgrounding.
@ejoliet , please review again to see if the PR is ready to merge. |
ejoliet
approved these changes
Aug 2, 2017
|
email notification works. I was on wireless network, once i switch to LAN, i got the email. SMTP trick... so all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-11387
Background jobs from one page(client app) may not be applicable in another page. This PR add the ability to limit what appears as background jobs.
Use /firefly/firefly.html and /firefly/firefly-dev.html to test that they do share background searches.
User /irsaviewer/ and /irsaviewer/timeseries to test that they are setup to not share background jobs.