Skip to content

IRSA-613: fixed: WCS match not working right for image that are very far apart #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2017

Conversation

robyww
Copy link
Contributor

@robyww robyww commented Jul 28, 2017

To test:

Show any image with M16 and any Image NGC 2264 and WCS match

@robyww robyww self-assigned this Jul 28, 2017
@robyww robyww requested a review from ejoliet July 28, 2017 23:27
@ejoliet
Copy link
Contributor

ejoliet commented Jul 29, 2017

In this branch, when i tested using your example and apply WCS match: one image goes out of the frame ('recenter' is displayed) and the other one stays. I guess it's the right answer for images whcih field is very far away.
Once the image goes away and i unselect the WCS match feature, the image doesn't come back to previous position. Is that the accepted behaviour? Otherwise, everything looks ok.
Good to go.
Thanks!

@ejoliet
Copy link
Contributor

ejoliet commented Jul 29, 2017

BTW, i've found that if i rotate the image and then do and undo target match, once i deselect it the image goes back to initial rotation. I think it should stay.
Test case: bring moving images from demo page, then rotate to north, apply target match and uncheck it, images go back to initial position. This is not the same as WCS match, once deselected, the images stays on their position. I'm not sure what is the behavior agreed or if there a better way to walk the user thru a best flow. @xiuqin might want to share her thoughts on that feature.

@robyww
Copy link
Contributor Author

robyww commented Jul 31, 2017

Once the image goes away and i unselect the WCS match feature, the image doesn't come back to previous position. Is that the accepted behaviour? Otherwise, everything looks ok.

Yes, it should both go back. I will work on that.

This is not the same as WCS match, once deselected, the images stays on their position. I'm not sure what is the behavior agreed or if there a better way to walk the user thru a best flow.

There is a lot of book keeping to do stuff like this. Right now, I am not inclined to do it, at least for this ticket. We can get use feedback to see how important it is.

@robyww robyww merged commit a392bc5 into dev Jul 31, 2017
@robyww robyww deleted the irsa-613-wcs-match branch August 1, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants