DM-11376: backgrounding job bug #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejoliet
requested changes
Jul 27, 2017
There was a problem hiding this comment.
@loitly, you might want to disable it in time series too before we get a better solution. Right now, if you have a long job running in periodogram or LC, the background monitor doesn't know how to handle to show result. Dom you see any easy solution?
|
After reviewing the problem, it's clear that we need to treat background searches differently then background packages. For now, I suggest we revert searches back to not backgroundable by default and only enable the ones we see fit. I'll enable backgrounding for catalog and top level searches in suit. What do you think, @xiuqin ? |
|
I agree. Please create a ticket for future design discussion to treat those two types of backgrounding hob differently.
Xiuqin
… On Jul 27, 2017, at 1:57 PM, Loi Ly ***@***.***> wrote:
After reviewing the problem, it's clear that we need to treat background searches differently then background packages. For now, I suggest we revert searches back to not backgroundable by default and only enable the ones we see fit. I'll enable backgrounding for catalog and top level searches in suit. What do you think, @xiuqin <https://github.com/xiuqin> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#425 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJlq0XK6t86eaZiljQRPIilGNvz-rqPoks5sSPnRgaJpZM4Okrvv>.
|
- on fail search, mask panel remained without error messages. - API should have backgroundable set to false, since background monitor may not be available.
…for catalog and suit searches.
loitly
force-pushed
the
DM-11376_bg_search_error
branch
from
5b7d2ca to
3c7ffd3
Compare
|
@ejoliet, I've made changes to this PR. Please review it again at your convenience. |
ejoliet
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-11376
use ticket to duplicate a search which will produce error.
use http://localhost:8080/firefly/demo/ffapi-highlevel-test.html to see that api searches are not backgroundable.