DM-11094: use default 'Time Series Tool' title #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined or empty string
ejoliet
reviewed
Jul 21, 2017
| @@ -33,6 +33,7 @@ import {getAppOptions} from '../../core/AppDataCntlr.js'; | |||
| import {HelpText} from './../../ui/HelpText.jsx'; | |||
|
|
|||
| const vFileKey = LC.FG_FILE_FINDER; | |||
| const DEFAULT_TITLE = 'Time Series Tool'; | |||
| /** | |||
There was a problem hiding this comment.
I thought this was set already in the entry point?
There was a problem hiding this comment.
It was set correctly when appTitle was undefined, but not when it was '', like in SUIT.
I did see defaults.appTitle = 'Time Series Tool' in IrsaViewer.js – if it's not used elsewhere, I would suggest removing it, since it's the default title anyway. @ejoliet what do you think?
There was a problem hiding this comment.
sure, i can remove it later.
cwang2016
reviewed
Jul 25, 2017
| @@ -115,12 +116,12 @@ export class LcViewer extends PureComponent { | |||
|
|
|||
| }; | |||
|
|
|||
| let title = appTitle; | |||
| let title = appTitle ? appTitle : DEFAULT_TITLE; // use default title when appTitle is undefined or '' | |||
There was a problem hiding this comment.
or 'title = appTitle || DEFAULT_TITLE;'
|
Review completes. It works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when appTitle is undefined or empty string
https://jira.lsstcorp.org/browse/DM-11094
To test, start Time Series Viewer from SUIT application:
LSST WISE Target: 9.6 -1.1, radius 100,
Check the title. It should not be empty or start with ':'