DM-11308: setup PDAC to only allow access to user with 'lsst_pdac' role #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoldina
approved these changes
Jul 21, 2017
| cn = cn == null ? kv[1] : cn; | ||
| } else if (kv[0].equalsIgnoreCase("ou")) { | ||
| ou = ou == null ? kv[1] : ou; | ||
| } else if (kv[0].equalsIgnoreCase("dc")) { |
There was a problem hiding this comment.
For ignorant people like me it would be helpful to know what 'ou', 'cn', and 'dc' are...
May be adding a link to some docs somewhere in OidcAdapter.javawould help.
| } | ||
| } | ||
| // is authenticated.. now check to see if user is allowed access | ||
| if (authRequired && allowAccess != null && allowAccess.size() > 0) { |
There was a problem hiding this comment.
Just curious how this Filter servlet is triggered and who is setting "allow" parameter? Can we be sure that allowAccess is non-null when authRequired is true?
There was a problem hiding this comment.
This filter is added to web.xml in lsst/suit. Beside the filter class, you can pass along parameters. allow is one of them.
I am defaulting to allow all. So, when allow is not given, we don't check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-11308
Setup PDAC to only allow access to users with 'lsst_pdac' or 'lsst_users' group.
Make sure to select "National Center for Supercomputing Applications" identity provider.
A pull request was also created for code changes in lsst/suit#4
You cannot deploy a version locally. However, you can test it here: https://facade.ipac.caltech.edu/suit/