Skip to content

IRSA-611:Period value isn't display anymore in result view #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2017
Merged

IRSA-611:Period value isn't display anymore in result view #414

merged 1 commit into from
Jul 19, 2017

Conversation

lznakano
Copy link
Contributor

After using plotly, the period is no longer displayed.
Thie reason is that LcPeriodPlotly failed to save the period value to the store.

To test:

  1. check out this branch and build firefly
  2. There is no change in ife. In ife, check out dev and build irsaviewer.
  3. run localhost:8080/irsaviewer/ts.html and then changes period, press "Accept".

IRSA-611:
36ac8ad 
  After using plotly, the period is no longer displayed.
  Thie reason is that  LcPeriodPlotly failed to save the period value to the store.
@lznakano lznakano requested a review from ejoliet July 18, 2017 23:36
ejoliet
ejoliet approved these changes Jul 19, 2017
View reviewed changes
Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm. good to merge. Thanks!

@lznakano lznakano merged commit 4bcc8e0 into dev Jul 19, 2017
@lznakano lznakano deleted the IRSA-611-PeriodValue branch July 19, 2017 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejoliet ejoliet ejoliet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lznakano @ejoliet