IRSA-601: labels change in error bars options #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoldina
reviewed
Jul 16, 2017
| @@ -119,7 +119,7 @@ export function fieldReducer({chartId, activeTrace}) { | |||
| fieldKey: errorMinusFieldKey(activeTrace, 'x'), | |||
| value: get(tablesourceMappings, ['error_x.arrayminus'], ''), | |||
| //tooltip: 'X error', | |||
| label: 'X Err\u2193:', | |||
| label: 'Error\u2193:', | |||
There was a problem hiding this comment.
We might want to remove tooltip and label properties from error and errorMinus fields here - they have no effect here and are actually defined in the Errors' render (as props to ColumnOrExpression).
|
Looks good. approved for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels for error bars option have changed.
X Err -> Error
Sym -> Symm
I took the opportunity to cleanup the code and remove duplicated constant.
Please, confirm change in UI and check that i didn't mess up the code. Thanks.