-
Notifications
You must be signed in to change notification settings - Fork 16
Heatmap (density) plot in multitrace chart #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chart Options:
- when scroll, top portion should be fixed and not scroll off.
- Color is no longer applicable and should not be an option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The color bars look very nice as is. But, once the chart is resized(400px width instead of 800px).. the labels render on top of each other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is good to merge. I don't see anything that would affect existing behavior. There are known issues that need to be resolved before it can be production ready as noted by Tatiana.
Object.assign(changes, fields); | ||
|
||
// reversescale is boolean | ||
changes[`data.${activeTrace}.reversescale`] = get(fields, `data.${activeTrace}.reversescale`, '').includes('true'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a WebUtil.toBoolean
function for this, if you want to use it.
Great feature!
Thanks. |
- show Color field only of marker.color is sopported for this trace type - move legend to the bottom if default colorbars are added
In the latest commit:
Heatmap does not show selected or highlighed from the table, only scatter trace shows them. The example is a top chart at http://localhost:8080/firefly/demo/ffapi-highlevel-charttest.html For scatter color maps, we do not display colorbar at the moment, as Emmanuel has noted. There is a ticket (https://jira.lsstcorp.org/browse/DM-11064) to address this issue. Regarding tooltip background, we'd like to keep as much Plotly behavior as possible. User can override it by giving custom layout or data configuration. Please, file the ticket for multitrace charts, if you see problems with filter, selection, or highlight. Selected and highlighted points are shown for active trace only, when active trace is scatter. You can change active trace by using the listbox on the toolbar. We might want to create a ticket to place an active trace on top of other traces of the same type. (Plotly keeps its own order for the different trace types.) Currently the latest trace is displayed on top. If traces are overlapping, the tooltips will be shown for the topmost trace. |
https://jira.lsstcorp.org/browse/DM-10832
Added heatmap trace type to multitrace chart with options and server side connection.
Known limitations:
colorbar can overlap.