download plotly image as PNG #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loitly
approved these changes
May 4, 2017
| downloadCounter++; | ||
| Plotly.downloadImage(chartDiv, { | ||
| format: 'png', | ||
| filename: `plotly-${chartId.replace(/\-.*$/, downloadCounter)}` |
There was a problem hiding this comment.
I think 'replace' and counter tracking is unnecessary. Even 'plotly', I don't think it's needed.
Filename should be chart.title or chart.chartId if title not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added save icon to download plotly chart as a png image.
The size of the images will match the size on display.
Known issue: in Safari, an image is not downloaded, but opened in the browser, it can be saved from there. Plotly team says it behaves this way because download attribute is not supported in Safari (http://caniuse.com/#feat=download) and they open the link instead.
Link to the ticket:
https://jira.lsstcorp.org/browse/DM-10275
(As discussed at SUIT meeting, we want to save PNG without an extra dialog and we prefer png to jpeg because it is lossless.)