IRSA-355: add extra style option to the LC viewer #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good to me. |
loitly
approved these changes
Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding additional style to the title so it can be layout on the right position of the icon.
Plus, the title will change depending on the page the user is. @ layouts have 2 different title.
See IRSA-355 for details.
Test: download both branches IFE and Firelfly related to IRSA-355. Build Firefly and IRSAViewer and check both LC viewer:
http://localhost:8080/firefly/ts.html (doesn't have icon, only title)
http://localhost:8080/irsaviewer/timeseries (have banner icon and title shifted)