DM-9395 Showing histogram on external viewer #351
Conversation
| const isMeta = isMetaDataTable(tbl_id); | ||
| if (isMeta || isCatalogTable(tbl_id)) { | ||
| const isDisplayTable = (hasTables && showTables); |
There was a problem hiding this comment.
I don't think isDisplayTable is needed because that's what showTables is supposed to represent. showTables should never be true unless hasTables is true.
|
Changes look fine. Good to merge. |
|
I've built the branch locally and when i click on the link {{show histogram}} the external viewer launched but shows the image search dialog and no histogram is shown. Is it only me? |
|
Ok, got it. Now that I can see external viewer , I've played around. One problem is when I click the 'charts' button. It sent the user to an error message page but there is no way I can go back to the histogram. If the drop down doesn't work or not usable, should it be removed? Or adds way to go back. |
…ror message for adding chart..
|
Emmanuel wrote: Resolve this issue by adding a 'OK' button on the dropdown which shows the error message. You may go back to the viewer by clicking the 'OK' button. |
…ion in Firefly viewer manager.
This development fixes the following:
the 'close' button exists when the chart is expanded from an external viewer with table, image and charts. Clicking the 'close' button, the page will go back to the original external viewer.
test:
go to the demo page:
http://localhost:8080/firefly/demo/ffapi-highlevel-test.html
click on 'show histogram'. an external viewer opens a new tab with a histogram chart on the page.