DM-9944 XYPlot with plotly library #350
Conversation
tgoldina
commented
Apr 12, 2017
tgoldina
commented
- Converted XYPlot into XYPlotHighcharts and XYPlotly implementations.
- Added lost click handling, to be able to select plotly chart from multi-chart viewer by a mouse click.
…atter plot functionality (zoom, highlight, select)
handling zoom and reversed axes (when both limited range and reversed axis are requires, autorange should be false and range array should be reversed).
margin adjusted for yticks length; tooltips are generated for new data (Firefox performance is very bad with plotly_hover)
modified colors for log scale, general cleanup
There was a problem hiding this comment.
Looks really good.
- Can you go ahead and add a save png to the toolbar? I think it is really straight forward. If it is not we can do it in another ticket.
UI bug:
- For the density, when you hover over the active point, it loses the depth (3rd) line.
UI issue:
- it is a little hard to see the select area box. Are there option that affect how it is drawn?
| @@ -111,8 +118,12 @@ export class PlotlyWrapper extends React.Component { | |||
|
|
|||
| render() { | |||
| const {style}= this.props; | |||
| // note: wrapper div is the target for the simulated click event | |||
| // when the original click event is lost and plotly_click is emitted instead | |||
There was a problem hiding this comment.
glad you documented the wrapper div
There was a problem hiding this comment.
For the density, when you hover over the active point, it loses the depth (3rd) line.
It's not exactly a bug. We point the point from the highlighted row, which might not be present in the decimated data. Though I can still find a bin to which the highlighted point belongs and add "represents".
There was a problem hiding this comment.
One minor thing. When zero points are selected via dragging, the chart is completely white-out without an indication on how to undo it. I would suggest not entering into this white-out mode if possible.
Otherwise, everything looks good. Selection and filtering work as well. 👍
When selection rectangle contains no points, remove it Move color bar to the left, when axis is on the right Do not adjust tick width when tick width obrained is not reasonable.
