Irsa 142-WCS match behavior is odd

[lznakano]

To test it,

1. build firefly
2. build irsaviewer in ife
3. Please follow the procedures in the video Louisa created (https://youtu.be/B-DfHOtWFGo)

For some reason, the image from irsaviewer is not the same as the one from the irsatest. I attached the old image in the ticket.

Thanks for testing!

[wmiipac]

the correct steps should be:
*checkout IRSA-142 branch in firefly
*checkout rc branch in ife
*build irsaviewer in ife, and follow Luisa's youtube

I built Atlas with irsaviewer(with Lijun's fix) point to my localhost
http://irsadev.ipac.caltech.edu:9072/data/SPITZER/C2D/

the wcs match problem is fixed.
There seem to be a problem when loading image from the irsaviewer, the image size is being ignored, the loading image panel had default size for wise set at 0.15 degree, see attached screenshot, but the image loaded is full size. irsatest has the correct wise image size.

[robyww]

This is not correct, you want to do the following:

 if ((plotInfo.addPlot&create) && plotInfo.viewerId) {
       groupId = plotInfo.viewerId;
       const viewer = getViewer(getMultiViewRoot(), plotInfo.viewerId);

       if (viewer && viewer.itemIdAry[0]) {
           const pv = getPlotViewById(visRoot(), viewer.itemIdAry[0]);
           if (pv) {
               groupId = pv.plotGroupId;
           }
       }
} 
else {
    ...

Right now you are getting just the first plotGroupId that is a risk. This way it will get the first PlotView in the active viewer and then get the plotGroup from that.

getActivePlotView is imported from PlotViewUtil.js
getViewer, getMultiViewRoot is imported from MultiViewCntrl.js

[lznakano]

Thank you for pointing out the potential risk. I will make the changes as you recommended.