IRSA-327: fix rounding problem #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… VOTable, reading precision VOTable if it exists
wmiipac
approved these changes
Apr 7, 2017
|
Precision is not yet generated from back-end service, Walter needs to add it. But the code is prepare to handle it ;-) |
loitly
approved these changes
Apr 10, 2017
|
@ejoliet if the precision is not set, the default is 8. Correct? |
|
Correct, but we can always change the default precision later. This is only applied to VOTable reader. We still have the problem for IPAC tables... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've set a default min precision for VOTable converter to data group, plus added the reading of a precision attribute from VOTable if it exists.
The guessing part of the format is only made in the first row. We need to improve that also for the IPAC table reader which is related to ticket raised during GOODS data-set release (IRSA-128).
Please check that this make sense and doesn't affect other things.
To test: do a periodogram calculation with period min=1, period max=2, rest as default for example, the first value of the VOTAble from the API is
1, the second is 1.000...This value should appear in the table/xy plot view with at least
8digit which is the default minimum precision.