Skip to content

IRSA-323: fix cancel button to dispatch id correctly to hide dialog #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

ejoliet
Copy link
Contributor

@ejoliet ejoliet commented Apr 6, 2017

Cancel button was not hiding the download dialog in LC, the button was doing anything. The id was the wrong one passed to the dispatch.

This is the fix. Please test.

@ejoliet ejoliet requested a review from loitly April 6, 2017 02:40
Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ejoliet ejoliet merged commit 4f43635 into rc Apr 6, 2017
@ejoliet ejoliet deleted the IRSA-323-fix-cancel-button branch April 6, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants