xyplot: support asymmetric errors #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loitly
approved these changes
Mar 17, 2017
| } | ||
| // set error related parameters | ||
| ['x', 'y'].forEach((axis) => { | ||
| const errorsType = get(flds, [`${axis}.errorsType`]); |
There was a problem hiding this comment.
get() take an array of paths or a string of path.
nothing is wrong with your statement.
but alternatively, you can do
get(flds, `${axis}.errorsType`) or
get(flds, [axis, 'errorsType'])
There was a problem hiding this comment.
I can not use the alternative ways you have suggested, because the fieldKey contains dot in it, ex. 'x.errorsType'. Since every fieldKey is converted into an object property, this is an example of the property, which can only be accessed using the square bracket notation.
I did it for convenience of mapping between fields and plot parameters, which are not flat as fields. In plot parameters, x is an object with all x-related parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-8685
To test: