Skip to content

IRSA-194: Handle bad ipac table upload #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2017
Merged

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Mar 15, 2017

https://caltech-ipac.atlassian.net/browse/IRSA-194

To ensure our application works properly, we will convert uploaded tables to fixed-length ipac format before displaying.

Also part of this pull request:

  • mapped AnyFileUpload into the CommandService scheme.
  • clean and combine multiple web.xml.

Some files from ife and suit were also changed. The changes are in the same branch.

Below is a sample catalog file that showed up with missing rows.

| ra          | dec        |
| double      | double     |
  32.073988     55.074964
 238.594530     22.404794
 250.679708     56.165833

@ejoliet
Copy link
Contributor

ejoliet commented Mar 16, 2017

Seems to work in tri-view but my test from local gator.html using API didn't work, is still shows 2 rows. Can you confirm that the fix is also in API used by Gator/Atlas?

@loitly
Copy link
Contributor Author

loitly commented Mar 17, 2017

Seems to work in tri-view but my test from local gator.html using API didn't work, is still shows 2 rows. Can you confirm that the fix is also in API used by Gator/Atlas?

You are right. I've made changes to also clean ipac table coming from external sources as well. This should fix the problem. Please verify.

@ejoliet
Copy link
Contributor

ejoliet commented Mar 17, 2017

Last commit fix also the problem in API. Thanks!

@loitly loitly merged commit 5a80b5e into dev Mar 17, 2017
@loitly loitly deleted the IRSA-194_handle_bad_upload_ipac branch March 17, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants