IRSA-174: TSV mission list should display only WISE and Basic for now #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works as expected. |
ejoliet
reviewed
Mar 15, 2017
|
|
||
| const options = getAllConverterIds().map((id) => { | ||
| const options = missionOptions.map((id) => { |
There was a problem hiding this comment.
I guess this will be the object that has the column time, value, etc, right?
|
Before merging, please, changed the options list to ['wise', 'other'] in IFE counterpart. This branch from Firefly is good to go. But IFE branch is out of date right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://caltech-ipac.atlassian.net/browse/IRSA-174
To test:
git checkout this branch on both firefly and ife.
build irsaviewer in ife.
goto http://localhost:8080/irsaviewer/timeseries to verify that only WISE and Basic option in dropdown.