Skip to content

DM-9638 Remove unexpected image tab after a column for histogram is selected #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2017

Conversation

cwang2016
Copy link
Contributor

This development is to

  • Remove unexpected image tab and not unmount the column select ion popup after a column for Histogram is selected.
  • skip to check if the table used for selecting the column is a catalog table or an image meta table after the table is loaded.

test:

  • start a catalog search (or lsst catalog search from lsst-pdac-triview.html)
  • click 'Charts' (or 'Add Charts' for lsst)
  • click 'Histogram' or 'Scattered plot' radio button. click 'Cols' and select a column from the popup table.
  • the select column name is shown in the field for columns in chart select panel.

…ion popup after a column for Histogram is selected.
@ejoliet
Copy link
Contributor

ejoliet commented Mar 9, 2017

works nice now. Thanks for fixing that.

@robyww robyww self-requested a review March 13, 2017 13:35
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes fixes only is part of the problem. It does not fix the FITS header case that @tgoldina added to the tickets.

Also, I am not sure the onlyData flag is the best way to approach this problem. I would like to get @loitly involved. We might want to have @loitly @tgoldina @cwang2016 and I talk about the best fix this morning.

robyww and others added 2 commits March 13, 2017 11:00
   - Must either defined a datasetInfoConverterId or DataSource meta data
   - All other tables are false
…n selection is metadata table.

Remove the use of 'onlyData' to catagorize the table which is neither a metadata table nor a catalog table.
@cwang2016
Copy link
Contributor Author

Remove the tag 'onlyData' and use the updated isMetaDataTable to check if the loaded table is meta data table or not.

@cwang2016
Copy link
Contributor Author

The issues for both popup tables on 'fits header' and 'column selection' are tested ok.

@cwang2016 cwang2016 merged commit fa21035 into dev Mar 13, 2017
@cwang2016 cwang2016 deleted the DM-9638-AddHistogramColumn branch March 13, 2017 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants