DM-9590 XY plot is unrecoverable after it fails #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejoliet
approved these changes
Mar 6, 2017
There was a problem hiding this comment.
Works as expected and plot recovers after wrong column selection. Message is better but not sure about the 'invalid' word, i would expect something like more a "Non-existing" column but for now is ok to merge because it solve the issue and message gracefully. Thank you!!!
BTW, histogram shows a similar non user-friendly error message when it fails but it recovers after failing so is less important to fix now. I will raise separate ticket for messaging errors, which is a general issue for Firefly, common errors shown should always be meaningful to the user.
- full height suggest box rendering should not cause flicker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-9590
To test, place test.html attached to the ticket (with non-existent x and y) into firefly/demo deployment directory.