Skip to content

DM-7803: add time series launch capability to suit app. #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2017

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Mar 1, 2017

https://jira.lsstcorp.org/browse/DM-7803

On LSST PDAC, when searching for 'Deep Forced Source' data, there should be a button to view the time series data for the highlighted objectId.
If you upload a table with time series's metadata, there should be a button to view the table as time series.

To Test:

  • Check out 'DM-7803_triview_timeseries' branch in both firefly and suit repo.
  • Build suit and then goto http://localhost:8080/suit/
  • Search for "Deep Forced Source", then click on 'View Time Series' button at upper right corner to view the data in a separate window.
  • When uploading a table with time series metadata, i.e. 'timeCName', there should also be a 'View as Time Series' button at the same location

Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few observations:

  • If I sent the TS Viewer a bad table and then a good table it does not recover and work with the good table.
  • The launch button needs to stand out a little from the button right beside it.
  • When the TS viewer come up there are two almost identical tables in temp_file. One appears from the search the other look like a upload table.

Otherwise, looks good.

* or a message prompting the user to select rows first
*/
export class ActiveTableButton extends Component {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a little trouble figuring out how this all worked. The key is the onChanges function that takes a table_id and a highlighted row and return a boolean and a title. I think this should be documented.

@loitly loitly force-pushed the DM-7803_triview_timeseries branch from 0a802f0 to 84f03ed Compare March 3, 2017 00:39
@loitly
Copy link
Contributor Author

loitly commented Mar 3, 2017

Changes since last pushed:

  • fix highlighted row out of sync after sorting or filtering.
  • for lsst, show only first of multiimage. - trey
  • add bolded text to highlight the time series button.

const tbl_id = get(action, 'payload.request.META_INFO.tbl_id');
if (tbl_id === LC.RAW_TABLE) {
removeTablesFromGroup();
removeTablesFromGroup(LC.PERIODOGRAM_GROUP);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like now we clear the derived tables only on the new search. But if we don't remove the derived tables, when raw table changes, how do we keep raw table in sync with the related tables? If user filters Raw and Phase Folded tables separately, we can not synchronize the highlight index between them, can we?

Copy link
Contributor Author

@loitly loitly Mar 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tgoldina: ... how do we keep raw table in sync with the related tables? If user filters Raw and Phase Folded tables separately, we can not synchronize the highlight index between them, can we?

You are right. I think a filter of a raw table should trigger a reset condition.

@loitly loitly merged commit 3cd6e21 into dev Mar 3, 2017
@loitly loitly deleted the DM-7803_triview_timeseries branch March 3, 2017 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants