-
Notifications
You must be signed in to change notification settings - Fork 16
DM-7803: add time series launch capability to suit app. #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few observations:
- If I sent the TS Viewer a bad table and then a good table it does not recover and work with the good table.
- The launch button needs to stand out a little from the button right beside it.
- When the TS viewer come up there are two almost identical tables in temp_file. One appears from the search the other look like a upload table.
Otherwise, looks good.
* or a message prompting the user to select rows first | ||
*/ | ||
export class ActiveTableButton extends Component { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a little trouble figuring out how this all worked. The key is the onChanges function that takes a table_id and a highlighted row and return a boolean and a title. I think this should be documented.
0a802f0
to
84f03ed
Compare
Changes since last pushed:
|
const tbl_id = get(action, 'payload.request.META_INFO.tbl_id'); | ||
if (tbl_id === LC.RAW_TABLE) { | ||
removeTablesFromGroup(); | ||
removeTablesFromGroup(LC.PERIODOGRAM_GROUP); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like now we clear the derived tables only on the new search. But if we don't remove the derived tables, when raw table changes, how do we keep raw table in sync with the related tables? If user filters Raw and Phase Folded tables separately, we can not synchronize the highlight index between them, can we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tgoldina: ... how do we keep raw table in sync with the related tables? If user filters Raw and Phase Folded tables separately, we can not synchronize the highlight index between them, can we?
You are right. I think a filter of a raw table should trigger a reset condition.
https://jira.lsstcorp.org/browse/DM-7803
On LSST PDAC, when searching for 'Deep Forced Source' data, there should be a button to view the time series data for the highlighted objectId.
If you upload a table with time series's metadata, there should be a button to view the table as time series.
To Test: