Skip to content

DM-9467: changed labels accordingly to the reviewers feedback #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2017
Merged

DM-9467: changed labels accordingly to the reviewers feedback #320

merged 1 commit into from
Feb 28, 2017

Conversation

ejoliet
Copy link
Contributor

@ejoliet ejoliet commented Feb 27, 2017

Labels have been updated according to the ticket.
Please, make sure that nothing is broken and labels are changed.

@ejoliet ejoliet requested review from xiuqin, wmiipac and robyww February 27, 2017 20:10
@robyww robyww assigned robyww and ejoliet and unassigned robyww Feb 28, 2017
robyww
robyww approved these changes Feb 28, 2017
View reviewed changes
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

wmiipac
wmiipac approved these changes Feb 28, 2017
View reviewed changes
Copy link
Contributor

@wmiipac wmiipac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all labels, looks good. PR approved.

@ejoliet ejoliet merged commit 1165020 into dev Feb 28, 2017
@ejoliet ejoliet deleted the DM-9467-change-lc-labels branch February 28, 2017 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyww robyww robyww approved these changes

@wmiipac wmiipac wmiipac approved these changes

@xiuqin xiuqin Awaiting requested review from xiuqin

Assignees

@ejoliet ejoliet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejoliet @robyww @wmiipac