Skip to content

DM-9550: #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2017
Merged

DM-9550: #314

merged 1 commit into from
Feb 22, 2017

Conversation

lznakano
Copy link
Contributor

Fixed the color band radio button bug
Fixed saving color band FITS file issue
Correct the alignment issue
Hide the color band radio buttons when the file type is png or reg

Please test to see if it works as expected.

Thanks!

  Fixed the color band radio button bug
  Fixed saving color band FITS file issue
  Correct the alignment issue
  Hide the color band radio buttons when the file type is png or reg
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing it so fast. Just fix the one line I mentioned and merge.

@@ -334,7 +350,7 @@ function resultsSuccess(request, plot) {

var band = Band.NO_BAND;
if (bandSelect) {
band = Band[bandSelect];
band = Band[bandSelect.toUpperCase()];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Band is an Enum object, the right way to do this line is:

band= Band.get(bandSelect)

That converts the string (case insensitive) into the enum

@lznakano lznakano merged commit 6804c96 into dev Feb 22, 2017
@lznakano lznakano deleted the DM-9500-FITSDownLoagBugs branch February 22, 2017 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants