DM-9272: Clean up IRSA Time series viewer to prepare RC #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nicer, definitively an improvement. There is another ticket DM-9469 mentioning a need to have a title, just in case you are able to add it as part of the improvements. Otherwise that's good to be merged. Thanks! |
ejoliet
approved these changes
Feb 18, 2017
|
Review completes. Good to have the fixing and cleaning. |
|
@ejoliet, in regard to DM-9469, where should the title be? It says 'first page'. Is that the results page where the mission and time column fields are? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-9272
To test:
http://localhost:8080/firefly/ts.html