Skip to content

DM-9490: python api enhancements #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2017
Merged

DM-9490: python api enhancements #309

merged 1 commit into from
Feb 21, 2017

Conversation

robyww
Copy link
Contributor

@robyww robyww commented Feb 17, 2017

  • extension can be added for any events
  • two new meta constants for overlay position
  • absolute position- positionCoord: '10.68479;41.26906;EQ_J2000'
  • position by row- positionCoordColumns: 'ra_obj;dec_obj;EQ_J2000',
  • fixed point extension not going into point selection mode if loaded first
  • fixed coverage so the option keys can be case insensitive
  • fixed mask not overlaying correctly

@robyww robyww self-assigned this Feb 17, 2017
@robyww robyww requested a review from loitly February 17, 2017 23:35
@robyww
DM-9490: python api enhancements
4655290 
  - extension can be added for any events
  - two new meta constants for overlay position
  - absolute position-  positionCoord: '10.68479;41.26906;EQ_J2000'
  - position by row-  positionCoordColumns: 'ra_obj;dec_obj;EQ_J2000',
  - fixed point extension not going into point selection mode if loaded first
  - fixed coverage so the option keys can be case insensitive
  - fixed mask not overlaying correctly
@robyww robyww force-pushed the dm-9490-python-api branch from b42f907 to 4655290 Compare February 21, 2017 16:40
loitly
loitly approved these changes Feb 21, 2017
View reviewed changes
Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to test, but code looks fine. Review completed.

@robyww robyww merged commit 72d99a5 into dev Feb 21, 2017
@robyww robyww deleted the dm-9490-python-api branch February 21, 2017 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loitly loitly loitly approved these changes

Assignees

@robyww robyww

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robyww @loitly