Skip to content

DM-9430 Fix Compass Layout #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2017
Merged

DM-9430 Fix Compass Layout #308

merged 3 commits into from
Feb 17, 2017

Conversation

cwang2016
Copy link
Contributor

the development includes

  • Locate the compass at the left corner of the image when the image is scrolled, zoomed, re-centered, rotated, flipped, etc.

test:

  • find a image by using 'Images' panel.
  • click 'compass' button from the image tool bar
  • apply image processing related buttons and see how the compass is rendered.

@cwang2016 cwang2016 changed the title DM-9430 Fix Compass Layout - render compass at the left corner on various image processing cases DM-9430 Fix Compass Layout Feb 17, 2017
@cwang2016 cwang2016 requested a review from robyww February 17, 2017 19:29
@cwang2016 cwang2016 self-assigned this Feb 17, 2017
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and it works very well. Using a saga was a good idea.

I would like you do to one thing:

For fits files without a coordinate systems the compass need to be a noop with out exceptions. I am not sure what happened before but it was probably a problem. I will send you a fits file from the LSST camera team that you can test with.

@ymeiymei
Copy link
Contributor

Tested with both LSST and WISE images. After the compasses are added to the images, zooming, moving, rotating, flipping....the images, the compasses keep staying in the images. Good work!

@cwang2016 cwang2016 merged commit f87095b into dev Feb 17, 2017
@cwang2016 cwang2016 deleted the DM-9430-CompassLayout branch February 17, 2017 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants