Skip to content

DM-8989: SQL constraint encoded #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2017
Merged

Conversation

ejoliet
Copy link
Contributor

@ejoliet ejoliet commented Feb 16, 2017

Please, check that it doesn't break anything else (Gator queries). Need to encode the constraint parameter passed in the request so it can cope with for example:
all-sky search with SQL constraint such as: objid like '%Themis'

Test: do a catalog search in NEOWISER Reactivation db, with the text search sql objid like '%Themis' in the SQL constraint text area on bottom of the catalog search panel.
Result should come back with 75 result same as if you are doing it from Gator page.

@ejoliet ejoliet self-assigned this Feb 16, 2017
@ejoliet ejoliet requested a review from loitly February 16, 2017 23:45
@ejoliet ejoliet changed the title DM-8989: need to encode the constraint value DM-8989: SQL constraint encoded Feb 16, 2017
Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done. It works fine.

@ejoliet ejoliet merged commit e34eaf0 into dev Feb 17, 2017
@ejoliet ejoliet deleted the DM-8989-sql-constraints-gator branch February 17, 2017 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants