DM-8833: Creates a basic download dialog based on selected rows #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create download dialog with extendable options - create download button that connects to single table or active table of a named group - update LcResults.jsx to use this new download dialog as an example
tgoldina
approved these changes
Jan 6, 2017
| <ValidationField | ||
| initialState= {{ | ||
| value: 'A sample download', | ||
| label : 'Title for this download:' |
There was a problem hiding this comment.
Is it possible to make the default title more descriptive, for example, by including the type (cutout or image) and the number of files to be downloaded?
There was a problem hiding this comment.
This is throw-away code. It serves as an example as well as for testing.
| }; | ||
|
|
||
| DownloadOptionPanel.defaultProps= { | ||
| groupKey: 'DownloadDialog', |
There was a problem hiding this comment.
Just noticed all these trailing commas. Looks like Trey finally moved you on his side. :)
There was a problem hiding this comment.
yes.. my lazy side wins.
| </div> | ||
| <div> | ||
| {help_id && <HelpIcon helpId={help_id} />} | ||
| </div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-8833
To test:
http://localhost:8080/firefly/lc.html
upper right corner 'Prepare Download' button is tied to active table.
select one or more rows, then click 'Prepare Download' to show the dialog.