Skip to content

DM-8648:fixed the flux unit bug #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2017
Merged

DM-8648:fixed the flux unit bug #260

merged 1 commit into from
Jan 4, 2017
+7 −1

Conversation

lznakano
Copy link
Contributor

@lznakano lznakano commented Jan 3, 2017

To test it,

  1. login JIRA and download the 1250p4106_1342188754_SpirePhoto_L20_PMP500_SPG14.0.fits file in DM-8648 and store somewhere in your locally.
  2. check out this branch and build the firefly
  3. start your tomcat server and then start the Image viewer in the browser by http://localhost:8080/firefly/
  4. open the fits file and check the flux unit.

Thanks!

@ymeiymei
Copy link
Contributor

ymeiymei commented Jan 3, 2017

I built the branch, used "External Images" and loaded the fits file above. I saw the unit of the image and the error image are "Jy/beam" and the the unit of the coverage is "1".
The bug is fixed.

@loitly
Copy link
Contributor

loitly commented Jan 4, 2017

The change looks good. Free to merge.

@loitly loitly closed this Jan 4, 2017
@loitly loitly reopened this Jan 4, 2017
@lznakano lznakano merged commit 1a093fe into dev Jan 4, 2017
@lznakano lznakano deleted the DM-8648-WrongFluxUnit branch January 4, 2017 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lznakano @ymeiymei @loitly