DM-8542 Add support for changing draw layer symbol and the size #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2016 16:24
robyww
approved these changes
Dec 16, 2016
| "violet":"#ee82ee", | ||
| "wheat":"#f5deb3","white":"#ffffff","whitesmoke":"#f5f5f5", | ||
| "yellow":"#ffff00","yellowgreen":"#9acd32"}; | ||
|
|
There was a problem hiding this comment.
are this colors for you background algorithm? You might want to clean it up so it uses single quotes and the keys are not quoted.
There was a problem hiding this comment.
I understand more this is a named color map to RGB. I think you want to this objects and the background utility routines to util/Color.js.
| let a = hsv.value * (1.0 - hsv.saturation); | ||
| let b = hsv.value * (1.0 - hsv.saturation * f); | ||
| let c = hsv.value * (1.0 - hsv.saturation * (1-f)); | ||
| let d = hsv.value; |
There was a problem hiding this comment.
you could use const for these instead of let
|
Yay!! Great extra feature for catalogs use on images. I think the options are clear enough and the fact that the change is applied immediately is also a extra bonus for usability. I like it a lot. Good job! |
…-change the symbol dialog to be only one as color dialog. -update drawlayer in color dialog
|
Some update:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The development mainly adds support for the user to change the symbol and its size when overlaying a catalog on an image including the features:
x, square, cross, diamond, circle, arrow, boxcircle, and dot.