DM-3612 scatter plot errorbars #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re the errors are displayed with the precision set on the server
|
review completes. looks good. test is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this ticket, the option is provided to enter a symmetric error for X and Y column. Asymmetric errors will be handled by a separate ticket.
A column or an expression can be entered next to X and Y field in plot options.
Good test is WISE color-color plots: use w[1,2,3,4]sigmpro as an uncertainty for w[1,2,3,4]mpro.
If less than 20 points are displayed, the error bar will have whiskers, otherwise no whiskers.
To test, bring up a catalog search in Firefly, choose WISE. After the default chart comes up, open the options, choose w1mpro for X, w1sigmpro for X Err, w2mpro for Y, w2sigmpro for Y Err. Do the search, zoom to see error bars, check tooltip to see the uncertainty, when available. (If not available, the corresponding cell in the table should show null.)