DM-8310: search Target match #252
Conversation
includes:
- search target match will show search target in center
- now more scroll bounds checking. Can put the image anywhere
- redoing scrolling
- recenter feature
- wcs match now puts images in center
- can load a table of moving objects
- found bugs in coordinate conversion caching, cache object moved to WebPlot
| retPV= updatePlotViewScrollXY(pv,makeScreenPt(srcSx-offPt.x,srcSy-offPt.y), false); | ||
| } | ||
| else if (visRoot.wcsMatchType===WcsMatchType.Target) { | ||
| // TODO: need compute offset of the active target from the center and match it |
There was a problem hiding this comment.
Very picky: i guess the TODO can be removed.
There was a problem hiding this comment.
This PR has 3 main features that cover:
- moving object images (MOST->irsaviewer),
- moving object table (i guess this is more for the future),
- Recenter feature (image dragged around the plot frame)
I've tested all.
The load moving images is working great!
To my understanding that part is OK to be merged. In that sense, I would be comfortable to make it available for testing by Vandana as part of the preparation for second RC (DM-8627).
The load of moving table though adds more features and interactions in tri-view which I'm not sure about. For example, i was surprised to see - in single image mode - the image changing when i clicked on an overlay symbol next to the highlighted one.
Can we discuss it further and expect more comments from @xiuqin, Luisa, Vandana, etc.?
Moving object potential users have particular needs and expectation.
I don't want to delay the merge but i feel we shouldn't take the decision alone. What do you think?
I mark it as approved because for me it looks good enough and is working but i still think we could expect some feedback to change it.
About the image to be re-centered, i guess this feature was introduced because of the need to address the problem of the moving target being outside the view, right? I think is a good implementation but again expect some feedback on that (label,etc.)
Search Target match includes:
- search target match will show search target in center
- now more scroll bounds checking. Can put the image anywhere
- redoing scrolling
- recenter feature
- wcs match now puts images in center
- can load a table of moving objects
- found bugs in coordinate conversion caching, cache object moved to WebPlot
To Test:
To Test a set of images with moving tagets defined
load Moving Imagessearch target matchTo Test loading a moving target table
load Moving Tablesearch target match