Skip to content

DM-8181: Add script download dialog #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2016
Merged

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Dec 8, 2016

https://jira.lsstcorp.org/browse/DM-8181

To test:

  • launch /firefly/lc.html
  • upload a raw table
  • click download on top right corner
  • enter at least 20 images, so that more than one download parts appear in the background monitor
  • when package completes, click on "Get Download Script"
  • play around with the different parameters to make sure it's working as intended

@cwang2016
Copy link
Contributor

All look good except finding two issues,

  • In the 'Download Retrieval Script' panel, the option 'Don't unzip the file' for 'Uncompression' is not selectable.
  • for the case only one download part shown in 'A sample download', click 'Download Now', the spinning doesn't go away when the download ends.

 - response to reviewer's comment
@loitly loitly merged commit ce1d613 into dev Dec 9, 2016
@loitly loitly deleted the DM-8181_download_script_dialog branch December 9, 2016 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants