Skip to content

DM-8579: vis server cleanup #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2016
Merged

DM-8579: vis server cleanup #247

merged 2 commits into from
Dec 6, 2016

Conversation

robyww
Copy link
Contributor

@robyww robyww commented Dec 2, 2016

  • moved some files our of server/visualize
  • created a ...server.visaulize.imageretrieve package
  • remove unused code
  • clean up some caching to simplify
  • removed aborting a plot
  • cleaned up managing plot context
  • moved the *Commands.java files to .../server/rpc
  • general cleanup including some java 7 syntax updates and javadocs

 - moved some files our of server/visualize
 - created a ...server.visaulize.imageretrieve package
 - remove unused code
 - clean up some caching to simplify
 - removed aborting a plot
 - cleaned up managing plot context
 - moved the *Commands.java files to .../server/rpc
 - general cleanup including some java 7 syntax updates and javadocs
Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine.


/*
* License information at https://github.com/Caltech-IPAC/firefly/blob/master/License.txt
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate addition.


/*
* License information at https://github.com/Caltech-IPAC/firefly/blob/master/License.txt
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate license info.


/*
* License information at https://github.com/Caltech-IPAC/firefly/blob/master/License.txt
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

/*
* License information at https://github.com/Caltech-IPAC/firefly/blob/master/License.txt
*/
package edu.caltech.ipac.firefly.server.visualize.imageretrieve;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here... also several more files below all have the same duplicate license info.

 - removed support for gif tiles
 - more java 7 updates
 - removed unnecessary paramters
 - bug fix: stretch not passing parameters correctly
 - bug fix: cube parameter not being placed into state properly
 - clean up from comments
@robyww robyww changed the title DM-8310: vis server cleanup DM-8579: vis server cleanup Dec 6, 2016
@robyww robyww merged commit d4b5ed5 into dev Dec 6, 2016
@robyww robyww deleted the dm-8579-cleanup branch December 6, 2016 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants