Skip to content

DM-7784-7963 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2016
Merged

DM-7784-7963 #238

merged 3 commits into from
Dec 8, 2016

Conversation

wmiipac
Copy link
Contributor

@wmiipac wmiipac commented Nov 23, 2016

DM-7784-7963

  • LC image retrieve use url instead of ibe for general purpose LCViewer
  • Add user input image cutout size in Phase Fold Panel.

wmiipac and others added 2 commits November 22, 2016 18:57
* LC image retireve use url instead of ibe for general purpose LCViewer
* Add user input image cutout size in Phase Fold Panel.
@ejoliet
Copy link
Contributor

ejoliet commented Nov 28, 2016

I've fixed a bug: the cutout size value wasn't passed along the url retrieve mechanism.

This PR has still couple of issues that should be addressed/discussed:

  • Place of the cutout size input field, might go to the image toolbar instead? (next to wcs checkbox?)
  • I feel that the change of the cutout size should be applied directly and not after clicking another row in the table (raw or phase folded tables)
  • Single exposure image retrieval function (wp request builder) need to be exposed as an entry point to the app if we want to control how the mission get their single exposure fetched (currently, for IRSA, a url column will be included in the LC table to be looked up and fetched directly), see related ticket DM-7840 about generic retrieval function via URL.

Based on other reviewer(s) feedback, separate issues will need to be created.

@ejoliet
Copy link
Contributor

ejoliet commented Nov 29, 2016

Another issue found is that the change of the cutout size doesn't picked up once the image has been cached with a previous size.

@ejoliet ejoliet merged commit bbc41d1 into dev Dec 8, 2016
@ejoliet ejoliet deleted the DM-7784-7963-image-url-retrieve branch December 8, 2016 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants