Skip to content

DM-8182: send email when package successfully completed. #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2016

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Nov 17, 2016

https://jira.lsstcorp.org/browse/DM-8182

  • email notification is working properly
  • it should also resend email when the email field has changed.

To test:

  • goto: firefly/lc.html
  • download something.
  • when email is given, you should receive email notification when job completes. you should also see 'Email notification sent' in the job status as well.
  • bring up background monitor and enter a different email. you should get email notifications for all completed jobs.

 - it should also resend email when the email field has changed.
@tgoldina
Copy link
Contributor

tgoldina commented Nov 18, 2016

I got the email when download request was completed, but none of resentEmails worked for me.

(This is the last item in your test sequence. When I enter a different email after the job is completed, I don't receive email.)

Update: the resend does not work only for single file download. For multiple files, things work as stated.

Copy link
Contributor

@tgoldina tgoldina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things:

  • resend does not work for one file (immediate) download
  • no indication in UI that email was resent (if it was sent before)

 - fixed immediate download showing up in background monitor.
@loitly
Copy link
Contributor Author

loitly commented Nov 18, 2016

I've pushed a commit to address the immediate download scenario. Please confirm.

 - fixed resend email not working when there is only 1 file.
@loitly
Copy link
Contributor Author

loitly commented Nov 19, 2016

I've pushed a commit to fix the single file scenario not getting email notification. Please confirm.

 - fixed email sent on immediate download
 - fixed email erroroneously sent on email field off-focus when value has not changed.
@loitly loitly merged commit a1d0e01 into dev Nov 21, 2016
@loitly loitly deleted the DM-8182_background_email_notification branch November 21, 2016 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants