DM-8288: Add support to show LSST SDSS images in triview #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robyww
commented
Nov 16, 2016
robyww
commented
- Now show LSST SDSS images for ccd (coadd does not yet work)
- added a little more logging and URLDownload and fixed logging bug
- add more control of URL downloads in WebPlotRequest
- Now show LSST SDSS images for ccd (coadd does not yet work) - added a little more logging and URLDownload and fixed logging bug - add more control of URL downloads in WebPlotRequest
cwang2016
reviewed
Nov 17, 2016
| const retval= {}; | ||
| var builder= makeCcdReqBuilder(table,row); | ||
| if (getCellValue(table, row, 'scienceCcdExposureId')) { | ||
| builder= makeCcdReqBuilder(table,row); |
There was a problem hiding this comment.
please check if line 63 duplicates line 61?
cwang2016
reviewed
Nov 17, 2016
| const filterId= Number(getCellValue(table, row, 'filterId')); | ||
|
|
||
| if (includeSingle) { | ||
| retval.single= builder(table,row, filterId+''); |
There was a problem hiding this comment.
are 'table' and 'row' ok to be passed for builder's first (plotId) and second (title) augments?
|
Review completes. Run test well. |
- bugs from found in code review - make overlay issue - changed lsst sdss url to use ids instead of id - fixed react issues - better logging from URLDownload
|
Both of those are real bugs. Thanks for finding them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.