DM-8179: Preserve background jobs and statuses beyond a browser session. #230
Conversation
- refactor AppDataCntlr.js
| import edu.caltech.ipac.firefly.util.event.Name; | ||
| import edu.caltech.ipac.util.StringUtils; | ||
| import org.apache.xpath.operations.*; |
| private Name name; | ||
| private EventTarget target; | ||
| private EventTarget target;; |
| @@ -91,6 +88,10 @@ public String toJsonString() { | |||
| return sb.toString(); | |||
| } | |||
|
|
|||
| public enum Scope {SELF, CHANNEL, USER, WORLD} | |||
|
|
|||
| public enum DataType {JSON, BG_STATUS, STRING} | |||
There was a problem hiding this comment.
Just curious, why did you move those enums down here? It was convenient to have them on top.
There was a problem hiding this comment.
it was not on purpose. i am guessing intelliJ has something to do with this.
| if (scope == ServerEvent.Scope.CHANNEL) { | ||
| this.channel = ServerContext.getRequestOwner().getEventChannel(); | ||
| } else if (scope == Scope.USER) { | ||
| this.userKey =ServerContext.getRequestOwner().getUserKey(); |
There was a problem hiding this comment.
The userKey - we rely on a cookie to preserve it, right?
| * @param actionStr | ||
| * @param scope | ||
| */ | ||
| public static void fireJsonAction(String actionStr, ServerEvent.Scope scope) { |
There was a problem hiding this comment.
picky: this overload might be redundant because you only call it from fireAction
There was a problem hiding this comment.
This is intended. The idea is that you should be able to send an action to self(connId), user, channel, or world without having to create a target.
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.stream.Collector; | ||
| import java.util.stream.Collectors; |
There was a problem hiding this comment.
duplicate and unused import
| @@ -114,24 +116,39 @@ public void close() { | |||
| * @param type action type. Either "app_data.wsConnAdded" or "app_data.wsConnRemoved" | |||
There was a problem hiding this comment.
typo in javadoc: 'event though' -> 'even though'
| if (!l.contains(q.getConnID())) l.add(q.getConnID()); | ||
| }); | ||
| FluxAction action = new FluxAction(type, connInfo); | ||
| ServerEventManager.fireAction(action, new ServerEvent.EventTarget(ServerEvent.Scope.SELF, seq.getConnID(), null, null)); |
There was a problem hiding this comment.
Just curious: So each client on the same channel will be notified of every new or closed connection? Why do we need it?
There was a problem hiding this comment.
This is done to support JS external viewer and python API(?). I am guessing this information may be useful in the future as well.
|
Good catch in regard to email sync. It's fixed in the latest commit. As for email not sent, it will be fixed in DM-8182. Thank you for the review. |
https://jira.lsstcorp.org/browse/DM-8179
Also, refactor AppDataCntlr.js
Background jobs are saved based on a userKey cookie which remained the same unless inactive for more than 2 weeks.
To test this, starts one or more downloads.
The downloads should be visible in other firefly instances of the same browser.
It should also remain after you reload the application or quit and come back some time later.
Also, cancel and remove are reflected in all instances as well.