-
Notifications
You must be signed in to change notification settings - Fork 16
DM-8006 Add xy chart to phase folding parameter setting panel using Highcharts #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My major concern is that the chart is being rerendered on mouse moves (readout actions) outside the popup. It should only re-render when the data change.
this.state = { | ||
fields, | ||
config: { | ||
chart: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to remove Highcharts.com from the chart corner by adding credits: {enabled: false} to the config
@@ -23,16 +23,21 @@ import {dispatchTableSearch} from '../../tables/TablesCntlr.js'; | |||
import Validate from '../../util/Validate.js'; | |||
import {LcPFOptionsPanel} from './LcPhaseFoldingPanel.jsx'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used
@@ -23,16 +23,21 @@ import {dispatchTableSearch} from '../../tables/TablesCntlr.js'; | |||
import Validate from '../../util/Validate.js'; | |||
import {LcPFOptionsPanel} from './LcPhaseFoldingPanel.jsx'; | |||
import {RAW_TABLE, PHASE_FOLDED} from './LcManager.js'; | |||
import ReactHighcharts from 'react-highcharts'; | |||
import {cloneDeep, get, set, omit, slice, replace, isNil} from 'lodash'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isNil is not used
/** | ||
* @summary 2D xyplot component on phase folding panel | ||
*/ | ||
class PhaseFoldingChart extends Component { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PhaseFoldingChart.propTypes for property validation might be useful
width | ||
}, | ||
title: { | ||
text: 'Flux vs. Phase' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just my opinion: I think this title does not add any new info. Also, title and legend together take too much space from the chart. I would put Period=... in the title, and remove legend.
…ormance. update the precision of the number displayed on the slide bar.
Great job! I really like the feature! It works flawless! As Tatiana says, removing the 'highchart.com' is good idea. I still think is good to have the legend with the value of the period. The title is fine too. I can think about couple of improvement but as i said before, to me is more a (great!) starting point and i don't think we are ready to call it for release unless LC users (i.e. David, Roc, Frank, Vandana, Luisa) can share more thoughts about it. |
…utton for starting phase folding dialog to be under 'phase folding' tab.
some update and fixing:
|
The implementation mainly,
Test:
Note: