DM-6617: fix parsing info link #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loitly
approved these changes
Nov 15, 2016
| @@ -262,7 +262,7 @@ private static String modifyToFullURL(String inStr, String targetStr) { | |||
| int endAnchor= s.indexOf(">",start); | |||
| if (targetStr!=null && endAnchor>0 && url!=null && | |||
| !s.substring(beginChar,endAnchor).contains("target=")) { | |||
| String rStr= "\\Q" + beginChar+url+beginChar + "\\E"; | |||
| String rStr = beginChar + url + beginChar; | |||
There was a problem hiding this comment.
Because rStr is used as a regex, simply removing the \Q \E will have a side-effect. If the url contains '?' for example, the modified code will fail.
There was a problem hiding this comment.
I've checked but those seems to not be part of regex characters set.
My test showed that the code above is also handling this kind of 'inStr' with '?' as mentioned:
res = WISE Preliminary Post-Cryo Single Exposure (L1b) Source Table (Superseded
Will merge the branch as it fixes at least the current problem. If something more complex and not resolved happens i will open a new ticket. Thanks for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the URL parsing when relative URL is found in master catalog table. In order to test, you need to build FF and redeploy the branch built.
Then go to 'catalog' search and check that 'info' and inner link in description are ok.