DM-7969: Offset time input field already introduced. #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwang2016
reviewed
Nov 14, 2016
| @@ -226,7 +226,7 @@ function onSearchSubmit(request) { | |||
| } else if ( get(request, PHASE_FOLDED) ) { | |||
| treq = TblUtil.makeFileRequest('Phase Folded', request[PHASE_FOLDED], null, {tbl_id:PHASE_FOLDED}); | |||
| treq.tblType='notACatalog'; | |||
| xyPlotParams = {x: {columnOrExpr: 'phase'}, y: {columnOrExpr: 'w1mpro_ep'}}; | |||
| xyPlotParams = {x: {columnOrExpr: 'phase'}, y: {columnOrExpr: 'w1mpro_ep', max:2}}; | |||
There was a problem hiding this comment.
Does this mean that the maximum of 'w1mpro_ep' is 2.0?
There was a problem hiding this comment.
No, you are right. Good point!
Mea culpa, will fix it.
|
review completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although offset seems to work, minor issues have been fixed in this PR.
Fix min/max period for the slider and phase axis max to 2.
Another bug has been raised DM-8261 to be fixed.